Create command request-chain to allow using testnets in bash
#3385
+211
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
changed the title
request-chain to allow using a testnet in bash
ma2bd
changed the title
request-chain to allow using a testnet in bashrequest-chain to allow using testnets in bash
afck
approved these changes
Feb 21, 2025
linera-client/src/client_options.rs
Outdated
| set_default: bool, | ||
| }, | ||
|
|
||
| /// Add a new followed chain (a chain without keypair) to the follow. |
There was a problem hiding this comment.
Suggested change
| /// Add a new followed chain (a chain without keypair) to the follow. | |
| /// Add a new followed chain (a chain without keypair) to follow. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
We need the same for owners as well - everything that has hash hardcoded in READMEs. |
deuszx
reviewed
Feb 21, 2025
CLI.md
Outdated
| @@ -794,9 +798,34 @@ Initialize a wallet from the genesis configuration | |||
|
|
|||
|
|
|||
|
|
|||
| ## `linera wallet request-chain` | |||
|
|
|||
| Request a chain from a faucet and add it to the wallet | |||
There was a problem hiding this comment.
I'd be more precise here - we're requesting creation of a new chain from the wallet.
Yes. Everytime we generate a key pair, we should print the owner/address on stdout. |
ma2bd
added a commit
that referenced
this pull request
Feb 23, 2025
## Motivation Allow removing the hard-coded OWNER variables from README tests ## Proposal Make sure to return the owner on stdout every time the CLI generates a key pair. ## Test Plan I modified the main README file. ## Links Continues #3385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Proposal
request-chainfollow-chainwhile we're at itTest Plan
Tested new CLI commands manually (together with
forget-keysandforget-chain) + CIRelease Plan
These changes COULD be backported to the latest
testnetbranch, then be released in a new SDK.